Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbGNO3W (ORCPT ); Tue, 14 Jul 2015 10:29:22 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:36054 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbbGNO3U convert rfc822-to-8bit (ORCPT ); Tue, 14 Jul 2015 10:29:20 -0400 MIME-Version: 1.0 In-Reply-To: References: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> Date: Tue, 14 Jul 2015 10:29:19 -0400 Message-ID: Subject: Re: [PATCH] gpu/drm/amdgpu: Include only if CONFIG_DEBUG_FS is set From: Alex Deucher To: Alexander Kuleshov Cc: David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Jammy Zhou , yanyang1 , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Maninder Singh , LKML , Maling list - DRI developers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 46 On Tue, Jul 14, 2015 at 4:18 AM, Alexander Kuleshov wrote: > Hello Alex, > > 2015-07-14 11:11 GMT+06:00 Alex Deucher : >> >> This patch breaks the build with debugfs enabled. >> > > I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds > successfully. Did I miss something? > Maybe I need to enable/disable anything else CONFIG_*? > > Thank you. Here's the error: CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function ‘amdgpu_debugfs_regs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1984:2: error: implicit declaration of function ‘debugfs_create_file’ [-Werror=implicit-function-declaration] ent = debugfs_create_file("amdgpu_regs", S_IFREG | S_IRUGO, root, ^ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1984:6: warning: assignment makes pointer from integer without a cast [enabled by default] ent = debugfs_create_file("amdgpu_regs", S_IFREG | S_IRUGO, root, ^ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function ‘amdgpu_debugfs_regs_cleanup’: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1996:2: error: implicit declaration of function ‘debugfs_remove’ [-Werror=implicit-function-declaration] debugfs_remove(adev->debugfs_regs); ^ cc1: some warnings being treated as errors make[4]: *** [drivers/gpu/drm/amd/amdgpu/amdgpu_device.o] Error 1 make[3]: *** [drivers/gpu/drm/amd/amdgpu] Error 2 make[2]: *** [drivers/gpu/drm] Error 2 make[1]: *** [drivers/gpu] Error 2 make: *** [drivers] Error 2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/