Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbbGNPhO (ORCPT ); Tue, 14 Jul 2015 11:37:14 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:65275 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753154AbbGNPhJ (ORCPT ); Tue, 14 Jul 2015 11:37:09 -0400 X-IronPort-AV: E=Sophos;i="5.15,472,1432598400"; d="scan'208";a="283964558" Message-ID: <55A52CA4.1040107@citrix.com> Date: Tue, 14 Jul 2015 17:37:08 +0200 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Boris Ostrovsky , CC: , , , , "Konrad Rzeszutek Wilk" , David Vrabel Subject: Re: [PATCH v2 19/20] xen/privcmd: Add support for Linux 64KB page granularity References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-20-git-send-email-julien.grall@citrix.com> <55A41BE4.3080104@oracle.com> <55A43638.4030503@citrix.com> <55A52A9E.2000400@oracle.com> In-Reply-To: <55A52A9E.2000400@oracle.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 34 Hi Boris, On 14/07/2015 17:28, Boris Ostrovsky wrote: > On 07/13/2015 06:05 PM, Julien Grall wrote: >> On 13/07/2015 22:13, Boris Ostrovsky wrote: >>> On 07/09/2015 04:42 PM, Julien Grall wrote: >>>> - >>>> struct remap_data { >>>> xen_pfn_t *fgmfn; /* foreign domain's gmfn */ >>>> + xen_pfn_t *efgmfn; /* pointer to the end of the fgmfn array */ >>> >>> It might be better to keep size of fgmfn array instead. >> >> It would means to have an other variable to check that we are at the >> end the array. > > > I thought that's what h_iter is. Is it not? h_iter is for the number of xen pfn in a Linux page. This is because the Linux privcmd interface is working with 4KB page and there may not be enough to fill a 64KB page. So we need another counter for the total number of foreign domain's gmfn. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/