Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbbGNRxT (ORCPT ); Tue, 14 Jul 2015 13:53:19 -0400 Received: from verein.lst.de ([213.95.11.211]:43610 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbGNRxS (ORCPT ); Tue, 14 Jul 2015 13:53:18 -0400 Date: Tue, 14 Jul 2015 19:53:17 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, snitzer@redhat.com Subject: Re: [PATCH 0/2] Configurable max discard size Message-ID: <20150714175317.GA30609@lst.de> References: <1436886139-18673-1-git-send-email-axboe@fb.com> <20150714160147.GA28031@lst.de> <55A532FC.6090206@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A532FC.6090206@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 13 On Tue, Jul 14, 2015 at 10:04:12AM -0600, Jens Axboe wrote: > Based on experimentation with two different vendors, 64MB would be a good > default. Question is how best to set that. At least with the current patch, > untouched, 'discard_max_bytes' will still show the hw max value. If I > default it to 64MB, we'd lose that information until people started bumping > it up in size. Maybe that's not such a big deal, however. Just expose the max value as another read-only sysfs value? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/