Date: Tue, 14 Jul 2015 20:08:57 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Andrey Vagin <avagin@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Cyrill Gorcunov <gorcunov@openvz.org>,
        Pavel Emelyanov <xemul@parallels.com>, Roger Luethi <rl@hellgate.ch>,
        Arnd Bergmann <arnd@arndb.de>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        David Ahern <dsahern@gmail.com>, Andy Lutomirski <luto@amacapital.net>,
        Pavel Odintsov <pavel.odintsov@gmail.com>
Subject: Re: [PATCH 12/24] task_diag: add a new group to get tasks memory
	mappings (v2)
Message-ID: <20150714180857.GC8088@redhat.com>
References: <1436172445-6979-1-git-send-email-avagin@openvz.org> <1436172445-6979-13-git-send-email-avagin@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436172445-6979-13-git-send-email-avagin@openvz.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 725
Lines: 36

On 07/06, Andrey Vagin wrote:
>
> +static int task_vma_num(struct mm_struct *mm)
> +{
> +	struct vm_area_struct *vma;
> +	int n_vma = 0;
> +
> +	if (!mm || !atomic_inc_not_zero(&mm->mm_users))
> +		return 0;
> +
> +	down_read(&mm->mmap_sem);
> +	for (vma = mm->mmap; vma; vma = vma->vm_next, n_vma++)
> +		;
> +
> +	up_read(&mm->mmap_sem);
> +	mmput(mm);
> +
> +	return n_vma;
> +}

Hmm. How about

	int task_vma_num(struct mm_struct *mm)
	{
		return mm->map_count;
	}

?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/