Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753168AbbGNSg2 (ORCPT ); Tue, 14 Jul 2015 14:36:28 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:44710 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839AbbGNSg0 (ORCPT ); Tue, 14 Jul 2015 14:36:26 -0400 Message-ID: <55A556A2.8040605@fb.com> Date: Tue, 14 Jul 2015 12:36:18 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Christoph Hellwig CC: , Subject: Re: [PATCH 0/2] Configurable max discard size References: <1436886139-18673-1-git-send-email-axboe@fb.com> <20150714160147.GA28031@lst.de> <55A532FC.6090206@fb.com> <20150714175317.GA30609@lst.de> In-Reply-To: <20150714175317.GA30609@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-07-14_08:2015-07-14,2015-07-14,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 21 On 07/14/2015 11:53 AM, Christoph Hellwig wrote: > On Tue, Jul 14, 2015 at 10:04:12AM -0600, Jens Axboe wrote: >> Based on experimentation with two different vendors, 64MB would be a good >> default. Question is how best to set that. At least with the current patch, >> untouched, 'discard_max_bytes' will still show the hw max value. If I >> default it to 64MB, we'd lose that information until people started bumping >> it up in size. Maybe that's not such a big deal, however. > > Just expose the max value as another read-only sysfs value? Sure, just didn't want to clutter it with Yet Another sysfs file. But we could add 'discard_max_hw_bytes', that would be the obvious choice. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/