Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753102AbbGNUBa (ORCPT ); Tue, 14 Jul 2015 16:01:30 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46850 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752897AbbGNUB2 (ORCPT ); Tue, 14 Jul 2015 16:01:28 -0400 Date: Tue, 14 Jul 2015 22:01:26 +0200 From: Pavel Machek To: Michael Welling Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Sebastian Reichel , Tony Lindgren , Ivaylo Dimitrov , Aaro Koskinen , Nishanth Menon , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux 4.2-rc1 broken Nokia N900 Message-ID: <20150714200125.GA26147@amd> References: <201507111405.06048@pali> <201507132234.22082@pali> <20150713215232.GA22584@deathray> <201507140002.44119@pali> <20150713223607.GA23001@deathray> <20150714071412.GA12844@pali> <20150714163342.GA8512@deathray> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150714163342.GA8512@deathray> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2609 Lines: 73 On Tue 2015-07-14 11:33:42, Michael Welling wrote: > On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Roh?r wrote: > > On Monday 13 July 2015 17:36:07 Michael Welling wrote: > > > On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Roh?r wrote: > > > > I think nothing special. I just call: > > > > > > > > export ARCH=arm > > > > export CROSS_COMPILE=arm-linux-gnueabi- > > > > make rx51_defconfig > > > > rm -f arch/arm/boot/zImage > > > > make -j12 zImage modules omap3-n900.dtb CONFIG_DEBUG_SECTION_MISMATCH=y > > > > cat arch/arm/boot/zImage arch/arm/boot/dts/omap3-n900.dtb > arch/arm/boot/zImage.new > > > > mv arch/arm/boot/zImage.new arch/arm/boot/zImage > > > > > > > > > > Where are you getting rx51_defconfig from? > > > > > > This does not appear to be in the kernel source any longer. > > > > > > Can you try the above with omap2plus_defconfig? > > > > > > > It is in my linux-n900 repository: https://github.com/pali/linux-n900 > > Repository contains more n900 specific patches but SPI code is unpatched > > > > https://github.com/pali/linux-n900/blob/HEAD/arch/arm/configs/rx51_defconfig > > > > Later in week I can try to compile also with omap2plus_defconfig... > > But in my opinion kernel should not crash with different configuration. > > True. > > Could you try the following change to the set_cs function and see if >it helps. Ok, so: 4.2-rc1 worked for me, IIRC. 4.2-rc2 oopses a lot. 4.2-rc2+ this patch oopses, too. I don't have serial console, so it is hard to tell if it is the same oops. Pavel > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c > index 5867384..666038b 100644 > --- a/drivers/spi/spi-omap2-mcspi.c > +++ b/drivers/spi/spi-omap2-mcspi.c > @@ -245,16 +245,18 @@ static void omap2_mcspi_set_enable(const struct spi_device *spi, int enable) > > static void omap2_mcspi_set_cs(struct spi_device *spi, bool enable) > { > + struct omap2_mcspi_cs *cs = spi->controller_state; > u32 l; > > - /* The controller handles the inverted chip selects > - * using the OMAP2_MCSPI_CHCONF_EPOL bit so revert > - * the inversion from the core spi_set_cs function. > - */ > - if (spi->mode & SPI_CS_HIGH) > - enable = !enable; > + if (cs) { > + -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/