Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753704AbbGNUxv (ORCPT ); Tue, 14 Jul 2015 16:53:51 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:12613 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbbGNUxW (ORCPT ); Tue, 14 Jul 2015 16:53:22 -0400 X-IronPort-AV: E=Sophos;i="5.15,474,1432623600"; d="scan'208";a="69668165" Message-ID: <55A576BF.9060609@broadcom.com> Date: Tue, 14 Jul 2015 13:53:19 -0700 From: Ray Jui User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bjorn Helgaas CC: SF Markus Elfring , Scott Branden , , , , LKML , , Hauke Mehrtens , "Julia Lawall" Subject: Re: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <55900A20.5070407@users.sourceforge.net> <20150714201059.GG24416@google.com> <55A56FBB.20203@broadcom.com> <20150714205128.GI24416@google.com> In-Reply-To: <20150714205128.GI24416@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1666 Lines: 47 On 7/14/2015 1:51 PM, Bjorn Helgaas wrote: > On Tue, Jul 14, 2015 at 01:23:23PM -0700, Ray Jui wrote: >> Hi Bjorn, >> >> On 7/14/2015 1:10 PM, Bjorn Helgaas wrote: >>> On Sun, Jun 28, 2015 at 04:52:16PM +0200, SF Markus Elfring wrote: >>>> From: Markus Elfring >>>> Date: Sun, 28 Jun 2015 16:42:04 +0200 >>>> >>>> The functions phy_exit() and phy_power_off() test whether their argument >>>> is NULL and then return immediately. >>>> Thus the test around the calls is not needed. >>>> >>>> This issue was detected by using the Coccinelle software. >>>> >>>> Signed-off-by: Markus Elfring >>> >>> I haven't seen a followup to Ray's review, but in the interest of making >>> progress, I updated and applied the patch as appended. I also reviewed >>> other phy_*() calls under drivers/pci, and they all look OK (with no >>> unnecessary tests for NULL). >>> >>> This is on the pci/host-iproc branch for v4.3. >>> >> >> Hmmm....I searched my mailbox but cannot find an email with this patch >> (while I remember I reviewed and commented on the initial version of >> this patch). It must have gone into some sub-folder or deleted by me by >> accident. My bad. >> >> Nevertheless,the current patch looks good to me! > > Thanks for checking it out! Can I add your Reviewed-by to the patch below? > Sure thanks! Reviewed-by: Ray Jui Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/