Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753955AbbGNVRx (ORCPT ); Tue, 14 Jul 2015 17:17:53 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:47102 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753133AbbGNVRw (ORCPT ); Tue, 14 Jul 2015 17:17:52 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 14 Jul 2015 23:17:50 +0200 X-ME-IP: 86.199.64.162 From: Robert Jarzmik To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org, arm@kernel.org, Sekhar Nori , Kevin Hilman , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Shawn Guo , Sascha Hauer , Imre Kaloz , Greg Ungerer , Roland Stigge , Tony Lindgren , Daniel Mack , Haojian Zhuang , Simtec Linux Team , Kukjin Kim , Krzysztof Kozlowski , linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 01/13] ARM: kill off set_irq_flags usage References: <1436711211-18223-1-git-send-email-robh@kernel.org> <1436711211-18223-2-git-send-email-robh@kernel.org> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 14 Jul 2015 23:14:45 +0200 In-Reply-To: <1436711211-18223-2-git-send-email-robh@kernel.org> (Rob Herring's message of "Sun, 12 Jul 2015 09:26:39 -0500") Message-ID: <87pp3ujvay.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 27 Rob Herring writes: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. As this works for several pxa boards : Acked-by: Robert Jarzmik -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/