Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbbGNVfq (ORCPT ); Tue, 14 Jul 2015 17:35:46 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:59185 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbGNVfp (ORCPT ); Tue, 14 Jul 2015 17:35:45 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 14 Jul 2015 23:35:44 +0200 X-ME-IP: 86.199.64.162 From: Robert Jarzmik To: Vaishali Thakkar Cc: Daniel Mack , Haojian Zhuang , Russell King , Julia Lawall , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: pxa: Use setup_timer References: <20150611052734.GA3943@vaishali-Ideapad-Z570> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 14 Jul 2015 23:32:51 +0200 In-Reply-To: <20150611052734.GA3943@vaishali-Ideapad-Z570> (Vaishali Thakkar's message of "Thu, 11 Jun 2015 10:57:35 +0530") Message-ID: <87lheijugs.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 30 Vaishali Thakkar writes: > Use the timer API function setup_timer instead of structure field > assignments to initialize a timer. > > A simplified version of the Coccinelle semantic patch that performs > this transformation is as follows: > > @change@ > expression e1, e2, a; > @@ > > -init_timer(&e1); > +setup_timer(&e1, a, 0UL); > ... when != a = e2 > -e1.function = a; > > Signed-off-by: Vaishali Thakkar Looks good to me. I'll queue that in pxa/for-next, thanks. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/