Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbbGNV5o (ORCPT ); Tue, 14 Jul 2015 17:57:44 -0400 Received: from netrider.rowland.org ([192.131.102.5]:54741 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752173AbbGNV5m (ORCPT ); Tue, 14 Jul 2015 17:57:42 -0400 Date: Tue, 14 Jul 2015 17:57:41 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Tomeu Vizoso cc: "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , Laurent Pinchart , Dmitry Torokhov , Len Brown , Pavel Machek , Greg Kroah-Hartman , Ulf Hansson , Kevin Hilman , Russell King , Krzysztof Kozlowski , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/2] PM / Runtime: Add pm_runtime_enable_recursive In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 33 On Tue, 14 Jul 2015, Tomeu Vizoso wrote: > > We may want to do the direct_complete_default thing in a different way. > > For example, the PM core could automatically set the direct_complete > > flag if a device has _none_ of the system suspend callbacks (i.e., no > > prepare, suspend, suspend_late, suspend_noirq, resume_noirq, > > resume_early, resume, or complete). Although it would be a little > > awkward to check this, it would be safer than inheriting > > direct_complete_default from the parent and it ought to solve Tomeu's > > problem just as well. > > Yeah, I think this is an improvement. Will give it a try. Sounds good. > > Here's a proposed patch to illustrate what I have in mind. Since it > > removes the only usage of pm_runtime_suspended_if_enabled(), it also > > removes the definition of that function. > > Will this patch be picked up as-is or should I add it to my series > with a proper changelog? You can add it to your series with my S-O-B: Signed-off-by: Alan Stern Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/