Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbbGNWPz (ORCPT ); Tue, 14 Jul 2015 18:15:55 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56010 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751863AbbGNWPy (ORCPT ); Tue, 14 Jul 2015 18:15:54 -0400 Date: Wed, 15 Jul 2015 00:15:52 +0200 From: Alexandre Belloni To: Vaishali Thakkar Cc: Joshua Kinard , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: rtc-ds1685: Use module_platform_driver Message-ID: <20150714221552.GF20482@piout.net> References: <20150707054614.GA9829@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150707054614.GA9829@vaishali-Ideapad-Z570> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1189 Lines: 43 On 07/07/2015 at 11:16:14 +0530, Vaishali Thakkar wrote : > Use module_platform_driver for drivers whose init and exit functions > only register and unregister, respectively. > > A simplified version of the Coccinelle semantic patch that performs > this transformation is as follows: > > @a@ > identifier f, x; > @@ > -static f(...) { return platform_driver_register(&x); } > > @b depends on a@ > identifier e, a.x; > @@ > -static e(...) { platform_driver_unregister(&x); } > > @c depends on a && b@ > identifier a.f; > declarer name module_init; > @@ > -module_init(f); > > @d depends on a && b && c@ > identifier b.e, a.x; > declarer name module_exit; > declarer name module_platform_driver; > @@ > -module_exit(e); > +module_platform_driver(x); > > Signed-off-by: Vaishali Thakkar Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/