Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbbGNWll (ORCPT ); Tue, 14 Jul 2015 18:41:41 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56357 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751993AbbGNWlk (ORCPT ); Tue, 14 Jul 2015 18:41:40 -0400 Date: Wed, 15 Jul 2015 00:41:38 +0200 From: Alexandre Belloni To: Maninder Singh Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, pankaj.m@samsung.com Subject: Re: [PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check Message-ID: <20150714224138.GG20482@piout.net> References: <1436338607-43389-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436338607-43389-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 28 Hi, On 08/07/2015 at 12:26:47 +0530, Maninder Singh wrote : > removing below static analysis error:- What tool did you use? > (error) Possible null pointer dereference: client > > if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) > ^^^^^^^ > Error comes beacause client is dereferenced before NULL check. > So probabily NULL this check is not required. > > Signed-off-by: Maninder Singh > --- > drivers/rtc/rtc-bq32k.c | 2 +- Applied, to rtc-next. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/