Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbbGOCMx (ORCPT ); Tue, 14 Jul 2015 22:12:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48197 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbbGOCMv (ORCPT ); Tue, 14 Jul 2015 22:12:51 -0400 Date: Tue, 14 Jul 2015 19:12:50 -0700 From: Greg KH To: Fabio Falzoi Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/10] Staging: fbtft: Use a struct to describe each LCD controller Message-ID: <20150715021250.GA4788@kroah.com> References: <1435646597-7612-1-git-send-email-fabio.falzoi84@gmail.com> <1435646597-7612-4-git-send-email-fabio.falzoi84@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435646597-7612-4-git-send-email-fabio.falzoi84@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 26 On Tue, Jun 30, 2015 at 08:43:10AM +0200, Fabio Falzoi wrote: > Use a struct flexfb_lcd_controller to holds chip properties, instead of > relying on a long 'if - else if' chain. > This allows to: > - use a simple linear search to verify if a certain LCD controller > model is supported or not. > - add support for a new LCD chip controller simply defining a new > flexfb_lcd_controller struct. > > Signed-off-by: Fabio Falzoi > --- > drivers/staging/fbtft/fbtft.h | 20 ++++ > drivers/staging/fbtft/flexfb.c | 212 ++++++++++++++++++++++------------------- > 2 files changed, 136 insertions(+), 96 deletions(-) I need the maintainers to sign off on this before I can take it, as it's not just a "simple" coding style fix. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/