Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 10 Feb 2003 20:34:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 10 Feb 2003 20:34:45 -0500 Received: from kim.it.uu.se ([130.238.12.178]:62083 "EHLO kim.it.uu.se") by vger.kernel.org with ESMTP id ; Mon, 10 Feb 2003 20:34:44 -0500 Date: Tue, 11 Feb 2003 02:44:19 +0100 (MET) From: Mikael Pettersson Message-Id: <200302110144.CAA15199@kim.it.uu.se> To: james.bottomley@steeleye.com Subject: 2.5.60 3c509 & net/Space.c problem Cc: clem@clem.clem-digital.net, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 35 >From Linus' 2.5.60 announcement: >James Bottomley : > o 3c509 fixes: correct MCA probing, add back ISA probe to Space.c This is somewhat broken. patch-2.5.60 has --- a/drivers/net/Space.c Mon Feb 10 10:39:23 2003 +++ b/drivers/net/Space.c Mon Feb 10 10:39:23 2003 @@ -224,6 +224,9 @@ #ifdef CONFIG_EL2 /* 3c503 */ {el2_probe, 0}, #endif +#ifdef CONFIG_EL3 + {el3_probe, 0}, +#endif #ifdef CONFIG_HPLAN {hp_probe, 0}, #endif but (a) there's no declaration for el3_probe() in scope at this point, leading to a compile error, and (b) el3_probe() is still 'static' in 3c509.c, leading to a linkage error (assuming a declaration for el3_probe() was added to Space.c to fix (a) first) Reverting the patch to Space.c solved the problem for me. Why the probe list entry? Isn't the module_init() in 3c509.c enough? /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/