Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751764AbbGOE51 (ORCPT ); Wed, 15 Jul 2015 00:57:27 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34949 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbbGOE50 (ORCPT ); Wed, 15 Jul 2015 00:57:26 -0400 Date: Wed, 15 Jul 2015 10:27:20 +0530 From: Sudip Mukherjee To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/23] staging: rtl8192e: Remove unused fields from rtllib_stats Message-ID: <20150715045720.GB17865@sudip-PC> References: <1436904266-25297-1-git-send-email-mateusz.kulikowski@gmail.com> <1436904266-25297-6-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436904266-25297-6-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 47 On Tue, Jul 14, 2015 at 10:04:08PM +0200, Mateusz Kulikowski wrote: > None of them are used in the driver. > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib.h | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index 8ba92ed..dc0653a 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -691,27 +691,8 @@ struct rtllib_frag_entry { > }; > > struct rtllib_stats { > - unsigned int tx_unicast_frames; > - unsigned int tx_multicast_frames; > - unsigned int tx_fragments; > - unsigned int tx_unicast_octets; > - unsigned int tx_multicast_octets; > - unsigned int tx_deferred_transmissions; > - unsigned int tx_single_retry_frames; > - unsigned int tx_multiple_retry_frames; > - unsigned int tx_retry_limit_exceeded; > unsigned int tx_discards; > - unsigned int rx_unicast_frames; > - unsigned int rx_multicast_frames; > - unsigned int rx_fragments; > - unsigned int rx_unicast_octets; > - unsigned int rx_multicast_octets; > - unsigned int rx_fcs_errors; > - unsigned int rx_discards_no_buffer; > - unsigned int tx_discards_wrong_sa; > unsigned int rx_discards_undecryptable; Dan had commented before that tx_discards and rx_discards_undecryptable are also not used. Their only uses are: ieee->ieee_stats.rx_discards_undecryptable++ and ieee->ieee_stats.tx_discards++ regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/