Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbbGOGa7 (ORCPT ); Wed, 15 Jul 2015 02:30:59 -0400 Received: from bastion.smtp.avagotech.com ([202.86.248.61]:50630 "EHLO sgpsmtp1.avagotech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbbGOGa5 (ORCPT ); Wed, 15 Jul 2015 02:30:57 -0400 X-Greylist: delayed 346 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Jul 2015 02:30:56 EDT Date: Tue, 14 Jul 2015 23:24:56 -0700 From: Sreekanth Reddy To: Yinghai Lu CC: , James Bottomley , , Linux-Scsi , "James E.J. Bottomley" , , Linux Kernel Mailing List , Christoph Hellwig , "Bjorn Helgaas" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH v3] [SCSI] mpt2sas, mpt3sas: Abort initialization if no memory I/O resources detected Message-ID: <20150715062456.GB19028@dhcp-135-24-192-118.lsi.com> References: <1436935796-28995-1-git-send-email-Sreekanth.Reddy@avagotech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1299 Lines: 33 On Tue, Jul 14, 2015 at 10:36:58PM -0700, Yinghai Lu wrote: > On Tue, Jul 14, 2015 at 9:49 PM, Sreekanth Reddy > wrote: > > Driver crashes if the BIOS do not set up at least one > > memory I/O resource. This failure can happen if the device is too > > slow to respond during POST and is missed by the BIOS, but Linux > > then detects the device later in the boot process. > > But pci subsystem should assign resources to those unassigned BAR. > > Do you mean even kernel can not assign resource to them? or it takes so long for > mpt FW to get ready? This is not an issue from mpt FW. I have just kept the same description provide by Timothy in his initial patch. But I observe that their may be chance of getting "unable to handle kernel NULL pointer dereference" kernel panic if no Memory Resource available in the PCI subsystem. So agreed to the Timothy proposal of aborting the driver initialization if it doesn't detect any Memory resource instead of whole system get into panic state. > > Thanks > > Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/