Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbbGOHro (ORCPT ); Wed, 15 Jul 2015 03:47:44 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:40336 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbbGOHrn (ORCPT ); Wed, 15 Jul 2015 03:47:43 -0400 Message-ID: <55A6100C.9000509@st.com> Date: Wed, 15 Jul 2015 09:47:24 +0200 From: Patrice Chotard User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Axel Lin , Kishon Vijay Abraham I CC: Kukjin Kim , Krzysztof Kozlowski , Srinivas Kandagatla , Maxime Coquelin , Heiko Stuebner , Kamil Debski , Maxime Ripard , Subject: Re: [PATCH] phy: Constify struct phy_ops variables References: <1436945631.10834.1.camel@ingics.com> In-Reply-To: <1436945631.10834.1.camel@ingics.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.198] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-07-15_03:2015-07-14,2015-07-15,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2747 Lines: 75 Hi Axel On 07/15/2015 09:33 AM, Axel Lin wrote: > The phy_ops variables are never modified after initialized in these > drivers, so make them const. > > Signed-off-by: Axel Lin > --- > Note, the change for drivers/phy/phy-tusb1210.c depends on > my previous patch "[PATCH] phy: ulpi_phy: Add const qualifier to ops". > > drivers/phy/phy-armada375-usb2.c | 2 +- > drivers/phy/phy-bcm-kona-usb2.c | 2 +- > drivers/phy/phy-berlin-sata.c | 2 +- > drivers/phy/phy-berlin-usb.c | 2 +- > drivers/phy/phy-brcmstb-sata.c | 2 +- > drivers/phy/phy-dm816x-usb.c | 2 +- > drivers/phy/phy-exynos-dp-video.c | 2 +- > drivers/phy/phy-exynos-mipi-video.c | 2 +- > drivers/phy/phy-exynos5-usbdrd.c | 2 +- > drivers/phy/phy-exynos5250-sata.c | 2 +- > drivers/phy/phy-hix5hd2-sata.c | 2 +- > drivers/phy/phy-miphy28lp.c | 2 +- > drivers/phy/phy-miphy365x.c | 2 +- > drivers/phy/phy-mvebu-sata.c | 2 +- > drivers/phy/phy-omap-usb2.c | 2 +- > drivers/phy/phy-qcom-apq8064-sata.c | 2 +- > drivers/phy/phy-qcom-ipq806x-sata.c | 2 +- > drivers/phy/phy-qcom-ufs-i.h | 2 +- > drivers/phy/phy-qcom-ufs-qmp-14nm.c | 2 +- > drivers/phy/phy-qcom-ufs-qmp-20nm.c | 2 +- > drivers/phy/phy-qcom-ufs.c | 2 +- > drivers/phy/phy-rcar-gen2.c | 2 +- > drivers/phy/phy-rockchip-usb.c | 2 +- > drivers/phy/phy-samsung-usb2.c | 2 +- > drivers/phy/phy-spear1310-miphy.c | 2 +- > drivers/phy/phy-spear1340-miphy.c | 2 +- > drivers/phy/phy-stih41x-usb.c | 2 +- > drivers/phy/phy-sun4i-usb.c | 2 +- > drivers/phy/phy-sun9i-usb.c | 2 +- > drivers/phy/phy-ti-pipe3.c | 2 +- > drivers/phy/phy-tusb1210.c | 2 +- > 31 files changed, 31 insertions(+), 31 deletions(-) > > diff --git a/drivers/phy/phy-armada375-usb2.c b/drivers/phy/phy-armada375-usb2.c > index 8ccc395..a3f1e73 100644 > --- a/drivers/phy/phy-armada375-usb2.c > +++ b/drivers/phy/phy-armada375-usb2.c > @@ -51,7 +51,7 @@ static int armada375_usb_phy_init(struct phy *phy) > return 0; > } > [snip] > > -static struct phy_ops phy_ops = { > +static const struct phy_ops phy_ops = { > .power_on = tusb1210_power_on, > .power_off = tusb1210_power_off, > .owner = THIS_MODULE, for drivers/phy/phy-miphy28lp.c, drivers/phy/phy-miphy365x.c and drivers/phy/phy-stih41x-usb.c Acked-by: Patrice Chotard Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/