Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbbGOIV1 (ORCPT ); Wed, 15 Jul 2015 04:21:27 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38419 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbbGOIVY (ORCPT ); Wed, 15 Jul 2015 04:21:24 -0400 Message-ID: <55A617FF.2030904@linaro.org> Date: Wed, 15 Jul 2015 09:21:19 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Boyd CC: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Rob Herring , Kumar Gala , Mark Brown , s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, pantelis.antoniou@konsulko.com, mporter@konsulko.com, stefan.wahren@i2se.com, wxt@rock-chips.com Subject: Re: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis. References: <1436521427-10568-1-git-send-email-srinivas.kandagatla@linaro.org> <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> <20150714220607.GP30412@codeaurora.org> In-Reply-To: <20150714220607.GP30412@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1974 Lines: 74 Thanks Stephen, On 14/07/15 23:06, Stephen Boyd wrote: > On 07/10, Srinivas Kandagatla wrote: >> +static int devm_nvmem_device_match(struct device *dev, void *res, void *data) >> +{ >> + struct nvmem_device **nvmem = res; >> + >> + if (!nvmem || !*nvmem) { >> + WARN_ON(!nvmem || !*nvmem); > > This could be > > if (WARN_ON(!nvmem || !*nvmem)) > Yep, will fix it. >> + return 0; >> + } >> + return *nvmem == data; >> +} >> + >> [..] >> + >> +/** >> + * nvmem_device_write() - Write cell to a given nvmem device >> + * >> + * @nvmem: nvmem device to be written to. >> + * @offset: offset in nvmem device. >> + * @bytes: number of bytes to write. >> + * @buf: buffer to be written. >> + * >> + * The return value will be an length of bytes written or non zero on failure. > > Should say negative value instead of non-zero? Length is > non-zero already. > > General nitpick comment: Kernel-doc allows for a standard return > syntax. Ok, I will fix such instances. > > Return: length of bytes written or negative value on failure. > >> diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h >> index f589d3b..74eed42 100644 >> --- a/include/linux/nvmem-provider.h >> +++ b/include/linux/nvmem-provider.h >> @@ -12,15 +12,9 @@ >> #ifndef _LINUX_NVMEM_PROVIDER_H >> #define _LINUX_NVMEM_PROVIDER_H >> >> -struct nvmem_device; >> +#include >> >> -struct nvmem_cell_info { >> - const char *name; >> - int offset; >> - int bytes; >> - int bit_offset; >> - int nbits; >> -}; > > Why does this move from provider to consumer? Can't we do put > this struct in the right place from the beginning? > I will take care of it in next version. --srini >> +struct nvmem_device; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/