Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbbGOIgv (ORCPT ); Wed, 15 Jul 2015 04:36:51 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:54948 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbbGOIgt (ORCPT ); Wed, 15 Jul 2015 04:36:49 -0400 Message-ID: <1436949405.2679.67.camel@tiscali.nl> Subject: Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver From: Paul Bolle To: Peter Hung Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Date: Wed, 15 Jul 2015 10:36:45 +0200 In-Reply-To: <1436843584-22616-1-git-send-email-hpeter+linux_kernel@gmail.com> References: <1436843584-22616-1-git-send-email-hpeter+linux_kernel@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1810 Lines: 85 Just a few nits, I'm afraid. On di, 2015-07-14 at 11:13 +0800, Peter Hung wrote: > --- /dev/null > +++ b/drivers/usb/serial/f81534.c > +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) > +{ > + [...] > +} static? > +void f81534_gpio_free(struct gpio_chip *chip, unsigned offset) > +{ > + [...] > +} Ditto. > +static struct gpio_chip f81534_gpio_chip_templete = { > + [...] > + .request = f81534_gpio_request, > + .free = f81534_gpio_free, > + [...] > +}; > +int f81534_ioctl_set_rs485(struct usb_serial_port *port, > + struct serial_rs485 __user *arg) > +{ > + [...] > +} Ditto. > +static int f81534_ioctl(struct tty_struct *tty, unsigned int cmd, > + unsigned long arg) > +{ > + [...] > + case TIOCSRS485: > + return f81534_ioctl_set_rs485(port, > + (struct serial_rs485 __user *) > + arg); > + [...] > +} > +int f81534_prepare_write_buffer(struct usb_serial_port *port, > + void *dest, size_t size) > +{ > + [...] > +} Ditto. > +static struct usb_serial_driver f81534_device = { > + [...] > + .prepare_write_buffer = f81534_prepare_write_buffer, > + .[...] > +}; > + > +static struct usb_serial_driver *const serial_drivers[] = { > + &f81534_device, NULL > +}; > + If you drop this empty line ... > +module_usb_serial_driver(serial_drivers, id_table); and add an empty line here, things look neater. > +MODULE_DESCRIPTION(DRIVER_DESC); > +MODULE_AUTHOR("Peter Hong "); > +MODULE_AUTHOR("Tom Tsai "); > +MODULE_LICENSE("GPL"); Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/