Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755834AbbGOJxj (ORCPT ); Wed, 15 Jul 2015 05:53:39 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:33194 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754804AbbGOJxh (ORCPT ); Wed, 15 Jul 2015 05:53:37 -0400 Date: Wed, 15 Jul 2015 11:53:49 +0200 From: Johan Hovold To: Peter Hung Cc: Paul Bolle , johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver Message-ID: <20150715095349.GF16243@localhost> References: <1436843584-22616-1-git-send-email-hpeter+linux_kernel@gmail.com> <1436949405.2679.67.camel@tiscali.nl> <55A61FF7.5030804@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55A61FF7.5030804@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 26 On Wed, Jul 15, 2015 at 04:55:19PM +0800, Peter Hung wrote: > Hi Paul & Johan > > Paul Bolle 於 2015/7/15 下午 04:36 寫道: > > Just a few nits, I'm afraid. > >> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) > >> +{ > >> + [...] > >> +} > > > > static? > > Thanks Paul for point this out. > > And sorry for Johan. It's seems to make a new patch V5. I'll merge > some minor fix with newer patch. No problem, I'll wait for v5. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/