Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbbGOLWX (ORCPT ); Wed, 15 Jul 2015 07:22:23 -0400 Received: from mail.kernel.org ([198.145.29.136]:53603 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752294AbbGOLWW (ORCPT ); Wed, 15 Jul 2015 07:22:22 -0400 Date: Wed, 15 Jul 2015 08:22:17 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Peter Zijlstra , namhyung@kernel.org, Jiri Olsa , Ingo Molnar , Linux Kernel Mailing List Subject: Re: [PATCH perf/core ] [BUGFIX] perf build-test: Add linux/export.h and lib/rbtree.c to MANIFEST Message-ID: <20150715112217.GB3868@kernel.org> References: <20150715060718.10311.42010.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150715060718.10311.42010.stgit@localhost.localdomain> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1939 Lines: 57 Em Wed, Jul 15, 2015 at 03:07:18PM +0900, Masami Hiramatsu escreveu: > Since linux/export.h and lib/rbtree.c are not listed in MANIFEST, > `make build-test` always fails as below (Note, to get these messages, > I've removed /dev/null redirect in tests/perf-targz-src-pkg); See: https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=4756e1966c4e1c00a2c6e379cea0322429d1a29b https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=0aefc3590afcc9ecbe173fc01fccbda0869d2f0a Summary: The fix below is wrong, the right one was pushed to Ingo and should make its way to Linus soon, - Arnaldo > ---- > CC util/hweight.o > ../../lib/hweight.c:1:26: fatal error: linux/export.h: > No such file or directory > #include > ^ > compilation terminated. > make[3]: *** [util/hweight.o] Error 1 > ---- > > ---- > GEN common-cmds.h > make[1]: *** No rule to make target `../../lib/rbtree.c', > needed by `python/perf.so'. Stop. > make[1]: *** Waiting for unfinished jobs.... > ---- > > Signed-off-by: Masami Hiramatsu > --- > tools/perf/MANIFEST | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST > index 09dc0aa..adce9de 100644 > --- a/tools/perf/MANIFEST > +++ b/tools/perf/MANIFEST > @@ -58,7 +58,9 @@ include/linux/list.h > include/linux/hash.h > include/linux/stringify.h > lib/hweight.c > +lib/rbtree.c > include/linux/swab.h > +include/linux/export.h > arch/*/include/asm/unistd*.h > arch/*/include/uapi/asm/unistd*.h > arch/*/include/uapi/asm/perf_regs.h > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/