Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752736AbbGOLwE (ORCPT ); Wed, 15 Jul 2015 07:52:04 -0400 Received: from cassarossa.samfundet.no ([193.35.52.29]:48997 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbbGOLwD (ORCPT ); Wed, 15 Jul 2015 07:52:03 -0400 Date: Wed, 15 Jul 2015 13:51:57 +0200 From: Hans-Christian Egtvedt To: Thomas Gleixner Cc: LKML , Haavard Skinnemoen , Jiang Liu , Russell King , Julia Lawall Subject: Re: [patch 1/3] avr32/at32ap: Consolidate chained IRQ handler install/remove Message-ID: <20150715115157.GA32762@samfundet.no> References: <20150713100425.719759717@linutronix.de> <20150713100606.351640193@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150713100606.351640193@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1757 Lines: 49 Around Mon 13 Jul 2015 20:31:09 -0000 or thereabout, Thomas Gleixner wrote: > Chained irq handlers usually set up handler data as well. We now have > a function to set both under irq_desc->lock. Replace the two calls > with one. > > Search and conversion was done with coccinelle. > > Reported-by: Russell King > Signed-off-by: Thomas Gleixner > Cc: Julia Lawall > Cc: Haavard Skinnemoen > Cc: Hans-Christian Egtvedt Acked-by: Hans-Christian Egtvedt > --- > arch/avr32/mach-at32ap/pio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: tip/arch/avr32/mach-at32ap/pio.c > =================================================================== > --- tip.orig/arch/avr32/mach-at32ap/pio.c > +++ tip/arch/avr32/mach-at32ap/pio.c > @@ -312,7 +312,6 @@ gpio_irq_setup(struct pio_device *pio, i > unsigned i; > > irq_set_chip_data(irq, pio); > - irq_set_handler_data(irq, (void *)gpio_irq); > > for (i = 0; i < 32; i++, gpio_irq++) { > irq_set_chip_data(gpio_irq, pio); > @@ -320,7 +319,8 @@ gpio_irq_setup(struct pio_device *pio, i > handle_simple_irq); > } > > - irq_set_chained_handler(irq, gpio_irq_handler); > + irq_set_chained_handler_and_data(irq, gpio_irq_handler, > + (void *)gpio_irq); > } > > /*--------------------------------------------------------------------------*/ -- mvh Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/