Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbbGONvh (ORCPT ); Wed, 15 Jul 2015 09:51:37 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:37997 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752471AbbGONve (ORCPT ); Wed, 15 Jul 2015 09:51:34 -0400 Message-ID: <55A6655F.8070400@hitachi.com> Date: Wed, 15 Jul 2015 22:51:27 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Peter Zijlstra , namhyung@kernel.org, Jiri Olsa , Ingo Molnar , Linux Kernel Mailing List Subject: Re: Re: [PATCH perf/core ] [BUGFIX] perf build-test: Add linux/export.h and lib/rbtree.c to MANIFEST References: <20150715060718.10311.42010.stgit@localhost.localdomain> <20150715112217.GB3868@kernel.org> In-Reply-To: <20150715112217.GB3868@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2719 Lines: 80 On 2015/07/15 20:22, Arnaldo Carvalho de Melo wrote: > Em Wed, Jul 15, 2015 at 03:07:18PM +0900, Masami Hiramatsu escreveu: >> Since linux/export.h and lib/rbtree.c are not listed in MANIFEST, >> `make build-test` always fails as below (Note, to get these messages, >> I've removed /dev/null redirect in tests/perf-targz-src-pkg); > > See: > > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=4756e1966c4e1c00a2c6e379cea0322429d1a29b > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=0aefc3590afcc9ecbe173fc01fccbda0869d2f0a > > Summary: The fix below is wrong, the right one was pushed to Ingo and > should make its way to Linus soon, Ah, OK. Since I just noticed that when I ran "make build-test" before releasing my patchset of perf probe cache. If it has successfully gone, please ignore this :) Thank you! > > - Arnaldo > >> ---- >> CC util/hweight.o >> ../../lib/hweight.c:1:26: fatal error: linux/export.h: >> No such file or directory >> #include >> ^ >> compilation terminated. >> make[3]: *** [util/hweight.o] Error 1 >> ---- >> >> ---- >> GEN common-cmds.h >> make[1]: *** No rule to make target `../../lib/rbtree.c', >> needed by `python/perf.so'. Stop. >> make[1]: *** Waiting for unfinished jobs.... >> ---- >> >> Signed-off-by: Masami Hiramatsu >> --- >> tools/perf/MANIFEST | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST >> index 09dc0aa..adce9de 100644 >> --- a/tools/perf/MANIFEST >> +++ b/tools/perf/MANIFEST >> @@ -58,7 +58,9 @@ include/linux/list.h >> include/linux/hash.h >> include/linux/stringify.h >> lib/hweight.c >> +lib/rbtree.c >> include/linux/swab.h >> +include/linux/export.h >> arch/*/include/asm/unistd*.h >> arch/*/include/uapi/asm/unistd*.h >> arch/*/include/uapi/asm/perf_regs.h >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/