Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752869AbbGOQAF (ORCPT ); Wed, 15 Jul 2015 12:00:05 -0400 Received: from skprod2.natinst.com ([130.164.80.23]:35098 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752115AbbGOQAC (ORCPT ); Wed, 15 Jul 2015 12:00:02 -0400 Message-ID: <55A6835D.1000401@ni.com> Date: Wed, 15 Jul 2015 10:59:25 -0500 From: Xander Huff User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sebastian Andrzej Siewior CC: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rt-users@vger.kernel.org, joe.hershberger@ni.com, joshc@ni.com, nathan.sullivan@ni.com, jaeden.amero@ni.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context References: <5574633F.7090004@kernel.org> <1436391502-2604-1-git-send-email-xander.huff@ni.com> <20150714142846.GB21820@linutronix.de> In-Reply-To: <20150714142846.GB21820@linutronix.de> X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 07/15/2015 10:59:25 AM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 07/15/2015 10:59:25 AM, Serialize complete at 07/15/2015 10:59:25 AM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=utf-8; format=flowed X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-07-15_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1440 Lines: 41 On 7/14/2015 9:28 AM, Sebastian Andrzej Siewior wrote: > * Xander Huff | 2015-07-08 16:38:22 [-0500]: > >> drivers/iio/adc/xilinx-xadc-core.c | 35 ++++++++++++----------------------- >> 1 file changed, 12 insertions(+), 23 deletions(-) >> >> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c >> index ce93bd8..b309ad3 100644 >> --- a/drivers/iio/adc/xilinx-xadc-core.c >> +++ b/drivers/iio/adc/xilinx-xadc-core.c >> @@ -1225,7 +1214,7 @@ static int xadc_probe(struct platform_device *pdev) >> if (ret) >> goto err_free_samplerate_trigger; >> >> - ret = request_threaded_irq(irq, xadc->ops->interrupt_handler, >> + ret = request_threaded_irq(irq, 0, > > NULL not 0 > Other than that, it looks good. Thanks. > If you managed to get this merged upstream then feel free to ping me and > I pick this into -RT. > >> xadc->ops->threaded_interrupt_handler, >> 0, dev_name(&pdev->dev), indio_dev); >> if (ret) > > Sebastian > Haven't got this merged in yet. I'm addressing another concern from Shubhrajyoti Datta and will include this change in my v3 I'll send out sometime next week, thanks! -- Xander Huff Staff Software Engineer National Instruments -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/