Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230AbbGORF2 (ORCPT ); Wed, 15 Jul 2015 13:05:28 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:33840 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbbGORF0 (ORCPT ); Wed, 15 Jul 2015 13:05:26 -0400 MIME-Version: 1.0 In-Reply-To: <1435916413-6475-2-git-send-email-k.kozlowski@samsung.com> References: <1435916413-6475-1-git-send-email-k.kozlowski@samsung.com> <1435916413-6475-2-git-send-email-k.kozlowski@samsung.com> From: Dan Streetman Date: Wed, 15 Jul 2015 13:05:06 -0400 X-Google-Sender-Auth: mwxsYKBt6qrsxGMPyvX1nPQmHRk Message-ID: Subject: Re: [PATCH 2/2] mm: zbud: Constify the zbud_ops To: Krzysztof Kozlowski Cc: Seth Jennings , Minchan Kim , Nitin Gupta , Linux-MM , linux-kernel , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2323 Lines: 66 On Fri, Jul 3, 2015 at 5:40 AM, Krzysztof Kozlowski wrote: > The structure zbud_ops is not modified so make the pointer to it as > pointer to const. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Dan Streetman > --- > include/linux/zbud.h | 2 +- > mm/zbud.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/zbud.h b/include/linux/zbud.h > index f9d41a6e361f..e183a0a65ac1 100644 > --- a/include/linux/zbud.h > +++ b/include/linux/zbud.h > @@ -9,7 +9,7 @@ struct zbud_ops { > int (*evict)(struct zbud_pool *pool, unsigned long handle); > }; > > -struct zbud_pool *zbud_create_pool(gfp_t gfp, struct zbud_ops *ops); > +struct zbud_pool *zbud_create_pool(gfp_t gfp, const struct zbud_ops *ops); > void zbud_destroy_pool(struct zbud_pool *pool); > int zbud_alloc(struct zbud_pool *pool, size_t size, gfp_t gfp, > unsigned long *handle); > diff --git a/mm/zbud.c b/mm/zbud.c > index 6f8158d64864..fa48bcdff9d5 100644 > --- a/mm/zbud.c > +++ b/mm/zbud.c > @@ -96,7 +96,7 @@ struct zbud_pool { > struct list_head buddied; > struct list_head lru; > u64 pages_nr; > - struct zbud_ops *ops; > + const struct zbud_ops *ops; > #ifdef CONFIG_ZPOOL > struct zpool *zpool; > const struct zpool_ops *zpool_ops; > @@ -133,7 +133,7 @@ static int zbud_zpool_evict(struct zbud_pool *pool, unsigned long handle) > return -ENOENT; > } > > -static struct zbud_ops zbud_zpool_ops = { > +static const struct zbud_ops zbud_zpool_ops = { > .evict = zbud_zpool_evict > }; > > @@ -302,7 +302,7 @@ static int num_free_chunks(struct zbud_header *zhdr) > * Return: pointer to the new zbud pool or NULL if the metadata allocation > * failed. > */ > -struct zbud_pool *zbud_create_pool(gfp_t gfp, struct zbud_ops *ops) > +struct zbud_pool *zbud_create_pool(gfp_t gfp, const struct zbud_ops *ops) > { > struct zbud_pool *pool; > int i; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/