MIME-Version: 1.0
In-Reply-To: <alpine.LRH.2.11.1507152033420.8351@namei.org>
References: <cover.1436903028.git.luto@kernel.org> <9f660ee708e58892bfa7012b6b9c840298e24544.1436903028.git.luto@kernel.org>
 <alpine.LRH.2.11.1507152033420.8351@namei.org>
From: Andy Lutomirski <luto@amacapital.net>
Date: Wed, 15 Jul 2015 10:09:49 -0700
Message-ID: <CALCETrWMBZ0p7P1FvtrYp5ChJXvvRzy0JpjS8KwUUa5m9gqgQA@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] capabilities: Ambient capabilities
To: James Morris <jmorris@namei.org>
Cc: Andy Lutomirski <luto@kernel.org>,
        Andrew Morton <akpm@linuxfoundation.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Serge Hallyn <serge.hallyn@ubuntu.com>,
        James Morris <james.l.morris@oracle.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        "Ted Ts'o" <tytso@mit.edu>, "Andrew G. Morgan" <morgan@kernel.org>,
        Linux API <linux-api@vger.kernel.org>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Michael Kerrisk <mtk.manpages@gmail.com>,
        Austin S Hemmelgarn <ahferroin7@gmail.com>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        Aaron Jones <aaronmdjones@gmail.com>,
        Serge Hallyn <serge.hallyn@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>, Markku Savela <msa@moth.iki.fi>,
        Kees Cook <keescook@chromium.org>, Jonathan Corbet <corbet@lwn.net>,
        Christoph Lameter <cl@linux.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1235
Lines: 44

On Wed, Jul 15, 2015 at 4:13 AM, James Morris <jmorris@namei.org> wrote:
> On Tue, 14 Jul 2015, Andy Lutomirski wrote:
>
>> ===== The proposed change =====
>>
>> This patch adds a fifth capability mask called the ambient mask
>> (pA).  pA does what most people expect pI to do.
>>
>
> This looks good, and I think it will lead to better overall security
> because people will find capabilities easier to use for real-world
> scenarios.
>
> Has it had enough security review?  This is a significant new behavior
> being added to a widely enabled security module.
>

I've reviewed it, as have Kees and Serge.  Of course, I wrote it, so
my review should be taken with many grains of salt.

I'll review it again between now and 4.3.  All of my security thought
cycles are currently taken up by a really nasty bug that dwarfs and
problems this code could possibly introduce :)

--Andy

>
>
> - James
> --
> James Morris
> <jmorris@namei.org>
>


-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/