Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbbGORbJ (ORCPT ); Wed, 15 Jul 2015 13:31:09 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:22081 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbbGORbE (ORCPT ); Wed, 15 Jul 2015 13:31:04 -0400 X-IronPort-AV: E=Sophos;i="5.15,481,1432623600"; d="scan'208";a="69749656" Message-ID: <55A698D0.3070203@broadcom.com> Date: Wed, 15 Jul 2015 10:30:56 -0700 From: Ray Jui User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Mark Rutland CC: Catalin Marinas , Will Deacon , Arnd Bergmann , Bjorn Helgaas , Hauke Mehrtens , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , Jon Mason Subject: Re: [PATCH v2 4/4] arm64: dts: Add Broadcom North Star 2 support References: <1436935343-4437-1-git-send-email-rjui@broadcom.com> <1436935343-4437-5-git-send-email-rjui@broadcom.com> <20150715092101.GB9627@leverpostej> In-Reply-To: <20150715092101.GB9627@leverpostej> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 36 On 7/15/2015 2:21 AM, Mark Rutland wrote: > Hi, > >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + bootargs = "earlycon=uart8250,mmio32,0x66130000"; >> + }; > > You shouldn't need those earlycon arguments if your driver has > of_earlycon support. If that's currently missing, could you add that > instead? > > Thanks, > Mark. > I can look into this and add the of_earlycon support for 8250_dw. It looks like it may be only a matter of hooking it up to the setup function in 8250_early.c, which is quite straightforward. So does it make more sense for me to do the following? 1) Drop the earlycon bootargs from ns2-svk.dts and continue the Broadcom iProc arm64 upstreaming process with the current patch series 2) Start a separate, new patch series with OF_EARLYCON support to 8250 DW driver Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/