Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbbGORuE (ORCPT ); Wed, 15 Jul 2015 13:50:04 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:34323 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbbGORuB (ORCPT ); Wed, 15 Jul 2015 13:50:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <1436876558-6674-1-git-send-email-dvlasenk@redhat.com> <55A502B6.5090806@cogentembedded.com> Date: Wed, 15 Jul 2015 20:49:59 +0300 Message-ID: Subject: Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32} From: Emmanuel Grumbach To: Denys Vlasenko Cc: Sergei Shtylyov , Denys Vlasenko , Emmanuel Grumbach , Johannes Berg , "John W. Linville" , Intel Linux Wireless , linux-wireless , netdev , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 29 On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko wrote: > On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov > wrote: >>> +#define IWL_READ_WRITE(static_inline) \ >>> +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ >>> +{ \ >>> + trace_iwlwifi_dev_iowrite8(trans->dev, ofs, val); \ >>> + iwl_trans_write8(trans, ofs, val); \ >>> +} \ >> [...] >>> >>> +#if !defined(CONFIG_IWLWIFI_DEVICE_TRACING) >>> +IWL_READ_WRITE(static inline) >> >> Not static_inline? > > Yes. Here we are putting two words, "static inline", in front of every > function definition. > -- I'll try to come up with a patch that is easier for me to read, but I am really busy right now. Ping me in a week if you have heard from me earlier. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/