Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbbGOTI1 (ORCPT ); Wed, 15 Jul 2015 15:08:27 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:44934 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbbGOTI0 (ORCPT ); Wed, 15 Jul 2015 15:08:26 -0400 Date: Wed, 15 Jul 2015 20:08:19 +0100 From: Russell King - ARM Linux To: Levente Kurusa Cc: ARM PORT , LKML Subject: Re: [PATCH] arm: fault.c: fix unhandled page fault message Message-ID: <20150715190819.GE7557@n2100.arm.linux.org.uk> References: <1436974250-4999-1-git-send-email-lkurusa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436974250-4999-1-git-send-email-lkurusa@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 24 On Wed, Jul 15, 2015 at 05:30:50PM +0200, Levente Kurusa wrote: > Even if the signal was handled using signal(2) the message > would be printed. Fix that by checking whether the signal > is handled. Why? Even if the application handles the signal, the point of this debugging is to have the kernel report the reason for the fault. Just because the application has installed a SIGSEGV handler to print some nice "oops" message, and to cleanly shut down (eg, like Xorg) doesn't mean we should hide this debugging. In fact, as such handlers generally get in the way of getting a decent dump from the application, having the kernel report this information is even more valuable in this situation. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/