Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbbGOU3J (ORCPT ); Wed, 15 Jul 2015 16:29:09 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:38770 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752995AbbGOU3I (ORCPT ); Wed, 15 Jul 2015 16:29:08 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 15 Jul 2015 13:29:07 -0700 X-Google-Sender-Auth: Yjsqthm-LMPLPebOldSC5KwTDCQ Message-ID: Subject: Re: [GIT PULL] ARC fixes for 4.2-rc3 From: Linus Torvalds To: Vineet Gupta Cc: lkml , "arc-linux-dev@synopsys.com" , Alexey Brodkin , Joel Porquet , Michal Marek Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 34 On Wed, Jul 15, 2015 at 12:27 AM, Vineet Gupta wrote: > > ARC fixes for 4.2-rc3 > > - Makefile changes (top-level+ARC) reinstates -O3 builds (regression since 3.16) So I pulled this, but it worries me a tiny bit. What happens if the environment has ARCH_CFLAGS set? The build will start using them. Sure, we've had this before, and maybe the ARCH_ prefix makes it unique enough, but generally I think we've tried to either (a) make sure they get initialized in the makefiles (eg the usual CFLAGS is set to empty by the arch things, so that we don't silently take them from the environment) (b) use KBUILD_ as a prefix (or at least K, as in KCFLAGS so I have this feeling that the makefile should initialize these guys to be empty before including the architecture makefile. I don't think this is a big deal, and I suspect we may have other cases where we do this, but I do not think that the *intention* was that people could use this as another KCFLAGS replacement... Comments? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/