Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbbGOWNJ (ORCPT ); Wed, 15 Jul 2015 18:13:09 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34221 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbbGOWNH (ORCPT ); Wed, 15 Jul 2015 18:13:07 -0400 Message-ID: <55A6DA84.8070504@gmail.com> Date: Wed, 15 Jul 2015 15:11:16 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ray Jui , Hauke Mehrtens , Catalin Marinas , Will Deacon , Arnd Bergmann , Mark Rutland , Bjorn Helgaas CC: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 3/4] arm64: Add Broadcom iProc family support References: <1436935343-4437-1-git-send-email-rjui@broadcom.com> <1436935343-4437-4-git-send-email-rjui@broadcom.com> <55A6D673.1040908@hauke-m.de> <55A6D8C8.6030901@broadcom.com> In-Reply-To: <55A6D8C8.6030901@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1851 Lines: 51 On 15/07/15 15:03, Ray Jui wrote: > > > On 7/15/2015 2:53 PM, Hauke Mehrtens wrote: >> On 07/15/2015 06:42 AM, Ray Jui wrote: >>> This patch adds support to Broadcom's iProc family of arm64 based SoCs >>> in the arm64 Kconfig and defconfig files >>> >>> Signed-off-by: Ray Jui >>> Reviewed-by: Scott Branden >>> --- >>> arch/arm64/Kconfig | 5 +++++ >>> arch/arm64/configs/defconfig | 2 ++ >>> 2 files changed, 7 insertions(+) >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index 318175f..969ef4a 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -162,6 +162,11 @@ source "kernel/Kconfig.freezer" >>> >>> menu "Platform selection" >>> >>> +config ARCH_BCM_IPROC >>> + bool "Broadcom iProc SoC Family" >>> + help >>> + This enables support for Broadcom iProc based SoCs >>> + >> >> Is this working correctly if we have ARCH_BCM_IPROC under ARM and ARM64? >> They are guarding the same SoC line, which now uses ARM64 CPUS. >> > > Yes, since the "ARCH=" parameter from the compiler helps to route it to > the right directory, arch/arm or arch/arm64, and you cannot compile both > in a single image. Same case for other SoCs, e.g., tegra (ARCH_TEGRA), > exynos (ARCH_EXYNOS), and etc. > > The benefit of sharing the same arch flag is that the device driver that > exists in iProc family of SoCs (both arm32 and arm64) can be guarded or > enabled properly. Yes, I like that as well, better maintain a single symbol across two architectures than multiple across multiple architectures. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/