Date: Wed, 15 Jul 2015 16:43:04 -0700 (PDT)
From: David Rientjes <rientjes@google.com>
To: Thomas Gleixner <tglx@linutronix.de>
cc: Christoph Lameter <cl@linux.com>, Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>, Pekka Enberg <penberg@kernel.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [patch V2] mm/slub: Move slab initialization into irq enabled
 region
In-Reply-To: <alpine.DEB.2.11.1507102306560.5760@nanos>
Message-ID: <alpine.DEB.2.10.1507151642541.9230@chino.kir.corp.google.com>
References: <20150710120259.836414367@linutronix.de> <20150710110242.25c84965@gandalf.local.home> <alpine.DEB.2.11.1507101421570.32416@east.gentwo.org> <alpine.DEB.2.11.1507102306560.5760@nanos>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1206
Lines: 28

On Fri, 10 Jul 2015, Thomas Gleixner wrote:

> Initializing a new slab can introduce rather large latencies because
> most of the initialization runs always with interrupts disabled.
> 
> There is no point in doing so. The newly allocated slab is not visible
> yet, so there is no reason to protect it against concurrent alloc/free.
> 
> Move the expensive parts of the initialization into allocate_slab(),
> so for all allocations with GFP_WAIT set, interrupts are enabled.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Christoph Lameter <cl@linux.com>
> Cc: Pekka Enberg <penberg@kernel.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Peter Zijlstra <peterz@infradead.org>

Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/