From: KY Srinivasan <kys@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, Dexuan Cui <decui@microsoft.com>
CC: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "Haiyang Zhang" <haiyangz@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Drivers: hv: vmbus: prevent new subchannel creation on
 device shutdown
Thread-Topic: [PATCH] Drivers: hv: vmbus: prevent new subchannel creation on
 device shutdown
Thread-Index: AQHQvk6KDQ3nQCJkBU2Sq3NyVNZ99J3dMbQg
Date: Thu, 16 Jul 2015 00:31:06 +0000
Message-ID: <BY2PR0301MB16547DFBB82BEBB69B4912DCA09A0@BY2PR0301MB1654.namprd03.prod.outlook.com>
References: <1436789934-11566-1-git-send-email-vkuznets@redhat.com>
	<19f503e369b04d01b79a1bde866a39f8@SIXPR30MB031.064d.mgd.msft.net>
 <87lheiybf5.fsf@vitty.brq.redhat.com>
In-Reply-To: <87lheiybf5.fsf@vitty.brq.redhat.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2015 00:31:06.5380
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0775
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1793
Lines: 50


> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Tuesday, July 14, 2015 9:03 AM
> To: Dexuan Cui
> Cc: devel@linuxdriverproject.org; KY Srinivasan; Haiyang Zhang; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] Drivers: hv: vmbus: prevent new subchannel creation
> on device shutdown
> 
> Dexuan Cui <decui@microsoft.com> writes:
> 
> >> -----Original Message-----
> >> From: Vitaly Kuznetsov
> >> Sent: Monday, July 13, 2015 20:19
> >> Subject: [PATCH] Drivers: hv: vmbus: prevent new subchannel creation on
> device
> >> shutdown
> >>
> >> When a new subchannel offer from host comes during device shutdown
> (e.g.
> >> when a netvsc/storvsc module is unloadedshortly after it was loaded) a
> >> crash can happen as vmbus_process_offer() is not anyhow serialized with
> >> vmbus_remove().
> >
> > How about vmbus_onoffer_rescind()?
> > It's not serialized with vmbus_remove() either, so I think there is an issue
> too?
> >
> > I remember when 'rmmod hv_netvsc', we get a rescind-offer message for
> > each subchannel.
> >
> 
> True, I think we have a race with rescind messages as well, we just
> never saw crashes for some reason. I'll think how we can make the fix
> more general.

In an earlier email I had outlined how I was planning to address original issue. I have a patch based on the logic
I had described - essentially put the burden on the probe call to ensure that the open (including sub-channels) is
complete before we return from probe. I will post this shortly.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/