From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Pan Xinhui <xinhuix.pan@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-pm@vger.kernel.org,
        "yanmin_zhang@linux.intel.com" <yanmin_zhang@linux.intel.com>,
        "mnipxh@163.com" <mnipxh@163.com>
Subject: Re: [PATCH V2] acpi-cpufreq: Fix an acpi perf unregister issue
Date: Thu, 16 Jul 2015 02:33:36 +0200
Message-ID: <10145531.HIolQ1AkeI@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20150713022859.GA10415@linux>
References: <559F67E4.7010509@intel.com> <20150713022859.GA10415@linux>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1225
Lines: 33

On Monday, July 13, 2015 07:58:59 AM Viresh Kumar wrote:
> On 10-07-15, 14:36, Pan Xinhui wrote:
> > 
> > As policy->cpu may not be same in acpi_cpufreq_cpu_init and
> > acpi_cpufreq_cpu_exit. There is a risk that we use different *cpu* to
> > un/register acpi performance. So acpi_processor_unregister_performance
> > may not be able to do the cleanup work. That causes a memory leak. And
> > if there will be another acpi_processor_register_performance call, it
> > may also fail thanks to the internal check of pr->performace.
> > 
> > So we add a field *acpi_perf_cpu* to fix this issue.
> > 
> > Signed-off-by: Pan Xinhui <xinhuix.pan@intel.com>
> > ---
> > Change from V1:
> > 	comments update
> > ---
> >  drivers/cpufreq/acpi-cpufreq.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Patch queued up for 4.3, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/