Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200AbbGPBMK (ORCPT ); Wed, 15 Jul 2015 21:12:10 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56437 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755158AbbGPBMF (ORCPT ); Wed, 15 Jul 2015 21:12:05 -0400 From: Kamal Mostafa To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com Cc: Stefan Wahren , Stephen Boyd , Kamal Mostafa Subject: [PATCH 3.19.y-ckt 249/251] clk: Fix JSON output in debugfs Date: Wed, 15 Jul 2015 18:09:30 -0700 Message-Id: <1437008972-9140-250-git-send-email-kamal@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1437008972-9140-1-git-send-email-kamal@canonical.com> References: <1437008972-9140-1-git-send-email-kamal@canonical.com> X-Extended-Stable: 3.19 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1836 Lines: 51 3.19.8-ckt4 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Wahren commit 7cb81136d2efe0f5ed9d965857f4756a15e6c338 upstream. key/value pairs in a JSON object must be separated by a comma. After adding the properties "accuracy" and "phase" the JSON output of /sys/kernel/debug/clk/clk_dump is invalid. So add the missing commas to fix it. Fixes: 5279fc402ae5 ("clk: add clk accuracy retrieval support") Signed-off-by: Stefan Wahren [sboyd@codeaurora.org: Added comment in function] Signed-off-by: Stephen Boyd [ kamal: backport to 3.19-stable: context ] Signed-off-by: Kamal Mostafa --- drivers/clk/clk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 2f14f57..9a50629 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -177,11 +177,12 @@ static void clk_dump_one(struct seq_file *s, struct clk *c, int level) if (!c) return; + /* This should be JSON format, i.e. elements separated with a comma */ seq_printf(s, "\"%s\": { ", c->name); seq_printf(s, "\"enable_count\": %d,", c->enable_count); seq_printf(s, "\"prepare_count\": %d,", c->prepare_count); - seq_printf(s, "\"rate\": %lu", clk_get_rate(c)); - seq_printf(s, "\"accuracy\": %lu", clk_get_accuracy(c)); + seq_printf(s, "\"rate\": %lu,", clk_get_rate(c)); + seq_printf(s, "\"accuracy\": %lu,", clk_get_accuracy(c)); seq_printf(s, "\"phase\": %d", clk_get_phase(c)); } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/