Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755231AbbGPCoU (ORCPT ); Wed, 15 Jul 2015 22:44:20 -0400 Received: from TYO201.gate.nec.co.jp ([210.143.35.51]:41454 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753862AbbGPCoT convert rfc822-to-8bit (ORCPT ); Wed, 15 Jul 2015 22:44:19 -0400 From: Naoya Horiguchi To: Andi Kleen CC: Andrew Morton , Dean Nelson , Tony Luck , "Kirill A. Shutemov" , Hugh Dickins , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Naoya Horiguchi Subject: Re: [PATCH v1 3/4] mm/memory-failure: give up error handling for non-tail-refcounted thp Thread-Topic: [PATCH v1 3/4] mm/memory-failure: give up error handling for non-tail-refcounted thp Thread-Index: AQHQv2iZqep/tm21g0+65vbSfJU/b53cyc6AgAACOwA= Date: Thu, 16 Jul 2015 02:41:07 +0000 Message-ID: <20150716024106.GA13135@hori1.linux.bs1.fc.nec.co.jp> References: <1437010894-10262-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1437010894-10262-4-git-send-email-n-horiguchi@ah.jp.nec.com> <20150716023307.GF1747@two.firstfloor.org> In-Reply-To: <20150716023307.GF1747@two.firstfloor.org> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.23] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <40B8A6E291556241882BF753BB4C77A1@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 26 On Thu, Jul 16, 2015 at 04:33:07AM +0200, Andi Kleen wrote: > > @@ -909,6 +909,15 @@ int get_hwpoison_page(struct page *page) > > * directly for tail pages. > > */ > > if (PageTransHuge(head)) { > > + /* > > + * Non anonymous thp exists only in allocation/free time. We > > + * can't handle such a case correctly, so let's give it up. > > + * This should be better than triggering BUG_ON when kernel > > + * tries to touch a "partially handled" page. > > + */ > > + if (!PageAnon(head)) > > + return 0; > > Please print a message for this case. In the future there will be > likely more non anonymous THP pages from Kirill's large page cache work > (so eventually we'll need it) OK, I'll do this. Thanks, Naoya Horiguchi-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/