Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbbGPEQL (ORCPT ); Thu, 16 Jul 2015 00:16:11 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35165 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbbGPEQJ (ORCPT ); Thu, 16 Jul 2015 00:16:09 -0400 Date: Wed, 15 Jul 2015 21:16:08 -0700 (PDT) Message-Id: <20150715.211608.1179325069980931613.davem@davemloft.net> To: decui@microsoft.com Cc: gregkh@linuxfoundation.org, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, kys@microsoft.com Subject: Re: [V2 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability From: David Miller In-Reply-To: <1436867936-17765-1-git-send-email-decui@microsoft.com> References: <1436867936-17765-1-git-send-email-decui@microsoft.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Jul 2015 21:16:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1854 Lines: 62 From: Dexuan Cui Date: Tue, 14 Jul 2015 02:58:56 -0700 > +int vmbus_sendpacket_hvsock(struct vmbus_channel *channel, void *buf, u32 len) > +{ > + struct vmpacket_descriptor desc; > + struct vmpipe_proto_header pipe_hdr; > + u32 packetlen; > + u32 packetlen_aligned; > + struct kvec bufferlist[4]; > + u64 aligned_data = 0; > + int ret; > + bool signal = false; Reverse christmas-tree (longest to shortest line) order these local variables, please. > +EXPORT_SYMBOL(vmbus_sendpacket_hvsock); EXPORT_SYMBOL_GPL() > +int vmbus_recvpacket_hvsock(struct vmbus_channel *channel, void *buffer, > + u32 bufferlen, u32 *buffer_actual_len) > +{ > + struct vmpacket_descriptor *desc; > + struct vmpipe_proto_header *pipe_hdr; > + u32 packet_len, payload_len; > + int ret; > + bool signal = false; Again, please use reverse christmas-tree order. > +void vmbus_get_hvsock_rw_status(struct vmbus_channel *channel, > + bool *can_read, bool *can_write) Second line is not properly indented, it should start exactly one column after the openning parenthesis on the previous line. > + hv_get_ringbuffer_availbytes(inring_info, > + bytes_avail_toread, > + bytes_avail_towrite); Again, improperly indented. > +extern int vmbus_sendpacket_hvsock(struct vmbus_channel *channel, > + void *buf, u32 len); > + Likewise. > +extern int vmbus_recvpacket_hvsock(struct vmbus_channel *channel, void *buffer, > + u32 bufferlen, u32 *buffer_actual_len); > + > +extern void vmbus_get_hvsock_rw_status(struct vmbus_channel *channel, > + bool *can_read, bool *can_write); Likewise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/