Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000AbbGPETT (ORCPT ); Thu, 16 Jul 2015 00:19:19 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608AbbGPETS (ORCPT ); Thu, 16 Jul 2015 00:19:18 -0400 Date: Wed, 15 Jul 2015 21:19:16 -0700 (PDT) Message-Id: <20150715.211916.1258342954251964451.davem@davemloft.net> To: decui@microsoft.com Cc: gregkh@linuxfoundation.org, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, kys@microsoft.com, pebolle@tiscali.nl Subject: Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature From: David Miller In-Reply-To: <1436868048-17875-1-git-send-email-decui@microsoft.com> References: <1436868048-17875-1-git-send-email-decui@microsoft.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Jul 2015 21:19:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 33 From: Dexuan Cui Date: Tue, 14 Jul 2015 03:00:48 -0700 > + pr_debug("hvsock_sk_destruct: called\n"); Debug logging just to state that a function is called is not appropriate, we have very sophisticated tracing facilities in the kernel that can do that transparently, and more. PLease remove this. > + if (hvsk->channel) { > + pr_debug("hvsock_sk_destruct: calling vmbus_close()\n"); Likewise, these kinds of debug logs are totally inappropriate. > +static int hvsock_release(struct socket *sock) > +{ > + /* sock->sk is NULL, if accept() is interrupted by a signal */ > + if (sock->sk) { > + __hvsock_release(sock->sk); > + sock->sk = NULL; > + } > + > + sock->state = SS_FREE; > + pr_debug("hvsock_release called\n\n"); Likewise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/