Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442AbbGPFQ7 (ORCPT ); Thu, 16 Jul 2015 01:16:59 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:57610 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbbGPFQ5 (ORCPT ); Thu, 16 Jul 2015 01:16:57 -0400 Message-ID: <55A73E3B.1010705@ti.com> Date: Thu, 16 Jul 2015 10:46:43 +0530 From: Keerthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Walmsley , Keerthy CC: , , , , , , Subject: Re: [PATCH v2 2/6] ARM: AM43xx: Add the PRM IRQ register offsets References: <1436334148-9309-1-git-send-email-j-keerthy@ti.com> <1436334148-9309-3-git-send-email-j-keerthy@ti.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 47 On Thursday 16 July 2015 08:08 AM, Paul Walmsley wrote: > On Thu, 16 Jul 2015, Paul Walmsley wrote: > >> On Wed, 8 Jul 2015, Keerthy wrote: >> >>> Add the PRM IRQ register offsets. >>> >>> Signed-off-by: Keerthy >> >> Please add more detail to your commit messages so they conform to >> Documentation/SubmittingPatches: >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n109 >> >> For example, this commit message should read something like: >> >> --- >> >> ARM: AM43xx: Add the PRM IRQ register offsets >> >> Add the PRM IRQ register offsets. This is needed to support PRM I/O >> wakeup on AM43xx. >> >> -- >> >> Basically, your patches need to provide context as to _why_ the change is >> needed. >> >> I've fixed the message for this patch, and queued it for v4.3, but >> please take care with this issue in the future. > > Also I've moved the AM43XX_PRM_IO_PMCTRL_OFFSET macro out of the AM43XX CM > section, since it doesn't belong there. Thanks Paul! > > > - Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/