Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbbGPHGR (ORCPT ); Thu, 16 Jul 2015 03:06:17 -0400 Received: from mail.kernel.org ([198.145.29.136]:58530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753768AbbGPHGQ (ORCPT ); Thu, 16 Jul 2015 03:06:16 -0400 Message-ID: <1437030372.3618.5.camel@hasee> Subject: Re: [PATCH v5 00/11] simplify block layer based on immutable biovecs From: Ming Lin To: Mike Snitzer Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Kent Overstreet , Dongsu Park , NeilBrown , "Alasdair G. Kergon" , Jeff Moyer , dm-devel@redhat.com Date: Thu, 16 Jul 2015 00:06:12 -0700 In-Reply-To: <20150713153537.GA30898@redhat.com> References: <1436166674-31362-1-git-send-email-mlin@kernel.org> <1436764355.30675.10.camel@hasee> <20150713153537.GA30898@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 51 On Mon, 2015-07-13 at 11:35 -0400, Mike Snitzer wrote: > I will do additional review to answer 1 and 2 above. And Jeff Moyer > told me he'd test the patchset on one of his testbeds. Hi Jeff, FYI, here is a fix for patch 1. Or you can pull from my tree. https://git.kernel.org/cgit/linux/kernel/git/mlin/linux.git/log/?h=block-generic-req diff --git a/block/blk-mq.c b/block/blk-mq.c index 40d08e3..181f343 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1287,12 +1287,12 @@ static void blk_mq_make_request(struct request_queue *q, struct bio *bio) return; } + blk_queue_split(q, &bio, q->bio_split); + if (!is_flush_fua && !blk_queue_nomerges(q) && blk_attempt_plug_merge(q, bio, &request_count, &same_queue_rq)) return; - blk_queue_split(q, &bio, q->bio_split); - rq = blk_mq_map_request(q, bio, &data); if (unlikely(!rq)) return; @@ -1374,12 +1374,12 @@ static void blk_sq_make_request(struct request_queue *q, struct bio *bio) return; } + blk_queue_split(q, &bio, q->bio_split); + if (!is_flush_fua && !blk_queue_nomerges(q) && blk_attempt_plug_merge(q, bio, &request_count, NULL)) return; - blk_queue_split(q, &bio, q->bio_split); - rq = blk_mq_map_request(q, bio, &data); if (unlikely(!rq)) return; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/