Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754993AbbGPKIe (ORCPT ); Thu, 16 Jul 2015 06:08:34 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35957 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754317AbbGPKIc (ORCPT ); Thu, 16 Jul 2015 06:08:32 -0400 Message-ID: <55A7829C.5040606@gmail.com> Date: Thu, 16 Jul 2015 11:08:28 +0100 From: Malcolm Priestley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dan Carpenter , Maninder Singh CC: "forest@alittletooquiet.net" , "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "gclement@baobob.org" , "linux-kernel@vger.kernel.org" , "joe@perches.com" , PANKAJ MISHRA Subject: Re: [RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree_skb References: <686357594.854551437036306449.JavaMail.weblogic@ep2mlwas07d> <20150716085430.GF5784@mwanda> In-Reply-To: <20150716085430.GF5784@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1245 Lines: 41 On 16/07/15 09:54, Dan Carpenter wrote: > On Thu, Jul 16, 2015 at 08:45:06AM +0000, Maninder Singh wrote: >> where we are checking for (pTDInfo->skb), we are using it in above line. >> and it does not look good, thats why we should remove thse checks and i have suggested >> changes. >> >> code snippet:- >> ----------------------- >> >> if (pTDInfo->skb_dma && (pTDInfo->skb_dma != pTDInfo->buf_dma)) > ^^^^^^^^^^^^^^^^ > This is allocated after ->skb so if ->skb_dma is non-NULL then ->skb is > also non-NULL. > >> dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma, >> pTDInfo->skb->len, DMA_TO_DEVICE); > > Is this a static checker warning? If so then it's a false positive. > This is old code dma_unmap_single never happens and is to be removed. pTDInfo->skb now originates from mac80211. I am in the process of tiding up pTDInfo that removes skb_dma. In the past, this driver several API's sharing the same device now it has just one. Regards Malcolm -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/