Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755333AbbGPK0q (ORCPT ); Thu, 16 Jul 2015 06:26:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56358 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755291AbbGPK0p (ORCPT ); Thu, 16 Jul 2015 06:26:45 -0400 Date: Thu, 16 Jul 2015 12:26:40 +0200 Message-ID: From: Takashi Iwai To: Keith Packard Cc: Jaroslav Kysela , Kailang Yang , Hui Wang , David Henningsson , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable HP amp and mute LED on HP Folio 9480m In-Reply-To: <86k2u1qlls.fsf@hiro.keithp.com> References: <1436892035-19589-1-git-send-email-keithp@keithp.com> <1436895871-2459-1-git-send-email-keithp@keithp.com> <86si8qw3gn.fsf@hiro.keithp.com> <86k2u1qlls.fsf@hiro.keithp.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 33 On Wed, 15 Jul 2015 21:14:39 +0200, Keith Packard wrote: > > Takashi Iwai writes: > > > Thanks! The new patch looks good, but I think we don't have to use > > the headset code, as your case looks more like a headphone, not a > > combo headset that needs the special handling. If so, the change can > > be reduced something like below. Could you check whether this is > > enough? > > Yes, that seems a lot simpler and works fine. I did remove the > led_power_filter setting; that doesn't seem relevant for GPIO-based > leds, and isn't necessary on my device in any case. > > This patch is now otherwise essentially the same as yours, with the > addition of comments. > > Thanks again for your help; it's always interesting to dive into some > different area of the kernel and see how it works. Great, I queued the patch now. It'll be included in the next pull request for 4.2-rc3. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/