Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898AbbGPKlv (ORCPT ); Thu, 16 Jul 2015 06:41:51 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:35340 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbbGPKlt (ORCPT ); Thu, 16 Jul 2015 06:41:49 -0400 Date: Thu, 16 Jul 2015 12:41:46 +0200 From: Thomas Graf To: Denys Vlasenko Cc: Alexander Duyck , Jozsef Kadlecsik , Herbert Xu , linux-kernel@vger.kernel.org Subject: Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords Message-ID: <20150716104146.GA22603@pox.localdomain> References: <1437040973-31531-1-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437040973-31531-1-git-send-email-dvlasenk@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 848 Lines: 20 On 07/16/15 at 12:02pm, Denys Vlasenko wrote: > +/* jhash - hash an arbitrary key > + * @k: sequence of bytes as key > + * @length: the length of the key > + * @initval: the previous hash, or an arbitray value > + * > + * The generic version, hashes an arbitrary sequence of bytes. > + * No alignment or length assumptions are made about the input key. > + * > + * Returns the hash value of the key. The result depends on endianness. > + */ > +u32 jhash(const void *key, u32 length, u32 initval) Shouldn't these live in lib/jhash.c or something? Otherwise everyone needs to depend on CONFIG_RHASHTABLE -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/