Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbbGPLFi (ORCPT ); Thu, 16 Jul 2015 07:05:38 -0400 Received: from mga01.intel.com ([192.55.52.88]:6787 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbGPLFh (ORCPT ); Thu, 16 Jul 2015 07:05:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,487,1432623600"; d="scan'208";a="763717687" From: "Kirill A. Shutemov" To: Dave Hansen Cc: Oleg Nesterov , "Kirill A. Shutemov" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Thomas Gleixner In-Reply-To: <55A3EFE9.7080101@linux.intel.com> References: <1436784852-144369-1-git-send-email-kirill.shutemov@linux.intel.com> <1436784852-144369-3-git-send-email-kirill.shutemov@linux.intel.com> <20150713165323.GA7906@redhat.com> <55A3EFE9.7080101@linux.intel.com> Subject: Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs Content-Transfer-Encoding: 7bit Message-Id: <20150716110503.9A4F5196@black.fi.intel.com> Date: Thu, 16 Jul 2015 14:05:03 +0300 (EEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 26 Dave Hansen wrote: > On 07/13/2015 09:53 AM, Oleg Nesterov wrote: > > On 07/13, Kirill A. Shutemov wrote: > >> > >> We don't really need ->vm_ops here: MPX VMA can be detected with VM_MPX > >> flag. And vma_merge() will not merge MPX VMA with non-MPX VMA, because > >> ->vm_flags won't match. > > > > Agreed. > > > > I am wondering if something like the patch below (on top of yours) makes > > sense... Not sure, but mpx_mmap() doesn't look nice too, and with this > > change we can unexport mmap_region(). > > These both look nice to me (and they both cull specialty MPX code which > is excellent). I'll run them through a quick test. Any update? -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/