Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932144AbbGPLUQ (ORCPT ); Thu, 16 Jul 2015 07:20:16 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:33520 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753892AbbGPLUO (ORCPT ); Thu, 16 Jul 2015 07:20:14 -0400 MIME-Version: 1.0 In-Reply-To: <1435253451-19817-1-git-send-email-grygorii.strashko@ti.com> References: <1435253451-19817-1-git-send-email-grygorii.strashko@ti.com> Date: Thu, 16 Jul 2015 13:20:13 +0200 Message-ID: Subject: Re: [PATCH 1/2] gpiolib: irqchip: prevent driver unloading if gpio is used as irq only From: Linus Walleij To: Grygorii Strashko Cc: Alexandre Courbot , Sekhar Nori , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Johan Hovold Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 21 On Thu, Jun 25, 2015 at 7:30 PM, Grygorii Strashko wrote: > Now nothing prevents GPIO driver from being unloaded if its gpios > were requested as GPIO IRQs only (without calling gpio_request()). > > Hence, add calls of try_module_get()/module_put() into > gpiochip_irq_reqres/relres() to track such scenario properly. > > Cc: Johan Hovold > Signed-off-by: Grygorii Strashko Patch applied with Alexandre's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/