Message-ID: <55A7A044.1040806@redhat.com>
Date: Thu, 16 Jul 2015 14:15:00 +0200
From: Denys Vlasenko <dvlasenk@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Thomas Graf <tgraf@suug.ch>
CC: Alexander Duyck <alexander.h.duyck@redhat.com>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        Herbert Xu <herbert@gondor.apana.org.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords
References: <1437040973-31531-1-git-send-email-dvlasenk@redhat.com> <20150716104146.GA22603@pox.localdomain>
In-Reply-To: <20150716104146.GA22603@pox.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1082
Lines: 27

On 07/16/2015 12:41 PM, Thomas Graf wrote:
> On 07/16/15 at 12:02pm, Denys Vlasenko wrote:
>> +/* jhash - hash an arbitrary key
>> + * @k: sequence of bytes as key
>> + * @length: the length of the key
>> + * @initval: the previous hash, or an arbitray value
>> + *
>> + * The generic version, hashes an arbitrary sequence of bytes.
>> + * No alignment or length assumptions are made about the input key.
>> + *
>> + * Returns the hash value of the key. The result depends on endianness.
>> + */
>> +u32 jhash(const void *key, u32 length, u32 initval)
> 
> Shouldn't these live in lib/jhash.c or something? Otherwise
> everyone needs to depend on CONFIG_RHASHTABLE

There is no CONFIG_RHASHTABLE, rhashtable.c is compiled unconditionally.

I will send an alternative patch, which creates jhash.c;
apply whichever version you like most.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/