Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755024AbbGPNNx (ORCPT ); Thu, 16 Jul 2015 09:13:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47763 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbbGPNNw (ORCPT ); Thu, 16 Jul 2015 09:13:52 -0400 From: Jeff Moyer To: Ming Lin Cc: Mike Snitzer , linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Kent Overstreet , Dongsu Park , NeilBrown , "Alasdair G. Kergon" , dm-devel@redhat.com Subject: Re: [PATCH v5 00/11] simplify block layer based on immutable biovecs References: <1436166674-31362-1-git-send-email-mlin@kernel.org> <1436764355.30675.10.camel@hasee> <20150713153537.GA30898@redhat.com> <1437030372.3618.5.camel@hasee> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Thu, 16 Jul 2015 09:13:49 -0400 In-Reply-To: <1437030372.3618.5.camel@hasee> (Ming Lin's message of "Thu, 16 Jul 2015 00:06:12 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1721 Lines: 57 Ming Lin writes: > On Mon, 2015-07-13 at 11:35 -0400, Mike Snitzer wrote: >> I will do additional review to answer 1 and 2 above. And Jeff Moyer >> told me he'd test the patchset on one of his testbeds. > > Hi Jeff, > > FYI, here is a fix for patch 1. > Or you can pull from my tree. > https://git.kernel.org/cgit/linux/kernel/git/mlin/linux.git/log/?h=block-generic-req Thanks, Ming. I'll let you know as soon as I have results worth sharing. Cheers, Jeff > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 40d08e3..181f343 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -1287,12 +1287,12 @@ static void blk_mq_make_request(struct request_queue *q, struct bio *bio) > return; > } > > + blk_queue_split(q, &bio, q->bio_split); > + > if (!is_flush_fua && !blk_queue_nomerges(q) && > blk_attempt_plug_merge(q, bio, &request_count, &same_queue_rq)) > return; > > - blk_queue_split(q, &bio, q->bio_split); > - > rq = blk_mq_map_request(q, bio, &data); > if (unlikely(!rq)) > return; > @@ -1374,12 +1374,12 @@ static void blk_sq_make_request(struct request_queue *q, struct bio *bio) > return; > } > > + blk_queue_split(q, &bio, q->bio_split); > + > if (!is_flush_fua && !blk_queue_nomerges(q) && > blk_attempt_plug_merge(q, bio, &request_count, NULL)) > return; > > - blk_queue_split(q, &bio, q->bio_split); > - > rq = blk_mq_map_request(q, bio, &data); > if (unlikely(!rq)) > return; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/