Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbbGPN0z (ORCPT ); Thu, 16 Jul 2015 09:26:55 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:46702 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753498AbbGPN0x (ORCPT ); Thu, 16 Jul 2015 09:26:53 -0400 Date: Thu, 16 Jul 2015 14:26:32 +0100 From: Russell King - ARM Linux To: Thomas Gleixner Cc: Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, Jason Cooper , Kukjin Kim , Krzysztof Kozlowski , Stephen Warren , Lee Jones , Alexander Shiyan , Maxime Ripard , linux-samsung-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage Message-ID: <20150716132632.GK7557@n2100.arm.linux.org.uk> References: <1436711211-18223-1-git-send-email-robh@kernel.org> <1436711211-18223-7-git-send-email-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 50 On Sun, Jul 12, 2015 at 06:43:56PM +0200, Thomas Gleixner wrote: > The probe function was added in the initial implementation of the > driver (2006), so it predates device tree. > > drivers/net/appletalk/ltpc.c > drivers/net/arcnet/com20020-isa.c > drivers/net/arcnet/com90io.c > drivers/net/arcnet/com90xx.c > > Surely not stuff you find on todays ARM systems > > drivers/net/ethernet/8390/ne.c > drivers/net/ethernet/8390/wd.c > drivers/net/ethernet/amd/lance.c > drivers/net/ethernet/amd/ni65.c > drivers/net/ethernet/amd/pcnet32.c pcnet32 is used on the Netwinder, which we still have supported in the ARM tree. Even worse, the Netwinder has the Cyberpro capture IRQ missing a resistor, so it defaults to "asserted" and can trigger a stuck-IRQ, so it's best not to allow probing of that known bad IRQ. > Ditto > > drivers/net/ethernet/smsc/smc911x.c > drivers/net/ethernet/smsc/smc9194.c > drivers/net/ethernet/smsc/smc91x.c > > Those might still be, but on the DT based boards the probing should be > completely irrelevant SA11x0 stuff uses smc91x.c > drivers/pcmcia/yenta_socket.c > > Russell might still use that. Some EBSA285 systems use that, Compaq Personal Server (which is my wireless AP using hostap) does. ucb1x00.c definitely uses IRQ probing on SA11x0 platforms. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/