Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755411AbbGPNwW (ORCPT ); Thu, 16 Jul 2015 09:52:22 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:35475 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbbGPNwU (ORCPT ); Thu, 16 Jul 2015 09:52:20 -0400 MIME-Version: 1.0 In-Reply-To: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> References: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> Date: Thu, 16 Jul 2015 15:52:19 +0200 Message-ID: Subject: Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check From: Linus Walleij To: Krzysztof Kozlowski , Rabin Vincent Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 43 On Thu, Jul 9, 2015 at 3:19 PM, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Fixes: d342571efea8 ("gpio: add ETRAXFS GPIO driver") > Cc: > > --- > > Patch only compile tested. > --- > drivers/gpio/gpio-etraxfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-etraxfs.c b/drivers/gpio/gpio-etraxfs.c > index 28071f4a5672..0e643140efde 100644 > --- a/drivers/gpio/gpio-etraxfs.c > +++ b/drivers/gpio/gpio-etraxfs.c > @@ -117,8 +117,8 @@ static int etraxfs_gpio_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > regs = devm_ioremap_resource(dev, res); > - if (!regs) > - return -ENOMEM; > + if (IS_ERR(regs)) > + return PTR_ERR(regs); > > match = of_match_node(etraxfs_gpio_of_table, dev->of_node); > if (!match) Rabin, can you ACK this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/