Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932149AbbGPOE4 (ORCPT ); Thu, 16 Jul 2015 10:04:56 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35417 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbbGPOEz (ORCPT ); Thu, 16 Jul 2015 10:04:55 -0400 Date: Thu, 16 Jul 2015 16:04:51 +0200 From: Thomas Graf To: Denys Vlasenko Cc: Alexander Duyck , Jozsef Kadlecsik , Herbert Xu , linux-kernel@vger.kernel.org Subject: Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords Message-ID: <20150716140451.GB22603@pox.localdomain> References: <1437040973-31531-1-git-send-email-dvlasenk@redhat.com> <20150716104146.GA22603@pox.localdomain> <55A7A044.1040806@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A7A044.1040806@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 31 On 07/16/15 at 02:15pm, Denys Vlasenko wrote: > On 07/16/2015 12:41 PM, Thomas Graf wrote: > > On 07/16/15 at 12:02pm, Denys Vlasenko wrote: > >> +/* jhash - hash an arbitrary key > >> + * @k: sequence of bytes as key > >> + * @length: the length of the key > >> + * @initval: the previous hash, or an arbitray value > >> + * > >> + * The generic version, hashes an arbitrary sequence of bytes. > >> + * No alignment or length assumptions are made about the input key. > >> + * > >> + * Returns the hash value of the key. The result depends on endianness. > >> + */ > >> +u32 jhash(const void *key, u32 length, u32 initval) > > > > Shouldn't these live in lib/jhash.c or something? Otherwise > > everyone needs to depend on CONFIG_RHASHTABLE > > There is no CONFIG_RHASHTABLE, rhashtable.c is compiled unconditionally. > > I will send an alternative patch, which creates jhash.c; > apply whichever version you like most. Right. I misread the CONFIG_TEST_RHASHTABLE. I'm fine with this then but agree with Daniel that this must be severely tested for performance regressions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/